[WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path <rdar://problem/30612463>
Created attachment 309794 [details] Patch
Comment on attachment 309794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309794&action=review > Source/WebKit2/UIProcess/WebProcessPool.cpp:526 > + m_databaseProcess->send(Messages::DatabaseProcess::InitializeWebsiteDataStore(parameters), 0); If there is a relevantDataStore that'll cause us to send the InitializeWebsiteDataStore event below, do we need to send it here as well?
(In reply to Maureen Daum from comment #2) > Comment on attachment 309794 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309794&action=review > > > Source/WebKit2/UIProcess/WebProcessPool.cpp:526 > > + m_databaseProcess->send(Messages::DatabaseProcess::InitializeWebsiteDataStore(parameters), 0); > > If there is a relevantDataStore that'll cause us to send the > InitializeWebsiteDataStore event below, do we need to send it here as well? Good call - Easy to fall in the trap of sending it twice. Wouldn't be a big deal, but definitely don't need to do it.
Created attachment 309815 [details] Patch
Comment on attachment 309815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309815&action=review > Source/WebKit2/UIProcess/WebProcessPool.cpp:532 > + auto parameters = relevantDataStore->databaseProcessParameters(); Unnecessary local variable.
Created attachment 309822 [details] Patch
Comment on attachment 309822 [details] Patch Clearing flags on attachment: 309822 Committed r216711: <http://trac.webkit.org/changeset/216711>
All reviewed patches have been landed. Closing bug.