Bug 171987 - Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
Summary: Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 172558
  Show dependency tree / graph
 
Reported: 2017-05-11 14:12 PDT by Alex Christensen
Modified: 2017-05-24 15:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2017-05-11 14:13 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (31.91 KB, patch)
2017-05-16 17:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (33.21 KB, patch)
2017-05-16 22:14 PDT, Alex Christensen 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-05-11 14:12:52 PDT 
Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should effect cookies used
Comment 1 Alex Christensen 2017-05-11 14:13:05 PDT 
Created attachment 309781 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-05-11 14:14:22 PDT 
<rdar://problem/32141505>
Comment 3 Geoffrey Garen 2017-05-11 14:14:42 PDT 
Comment on attachment 309781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309781&action=review

Did you mean to include a patch too, or is that in another bug?

> Tools/ChangeLog:3
> +        Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should effect cookies used

effect => affect
Comment 4 Alex Christensen 2017-05-11 14:16:13 PDT 
I haven't written the patch yet.  This is just the failing test.  I just needed to file the radar before I've finished the patch.
Comment 5 Alex Christensen 2017-05-16 17:20:34 PDT 
Created attachment 310325 [details]
Patch
Comment 6 Alex Christensen 2017-05-16 22:14:51 PDT 
Created attachment 310349 [details]
Patch
Comment 7 Alex Christensen 2017-05-17 09:52:12 PDT 
http://trac.webkit.org/r216977
Comment 8 Alex Christensen 2017-05-17 16:11:55 PDT 
http://trac.webkit.org/r217010
Comment 9 David Kilzer (:ddkilzer) 2017-05-24 15:59:47 PDT 
This caused leaks in TestWebKitAPI:

Bug 172558: REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
<https://bugs.webkit.org/show_bug.cgi?id=172558>