Bug 171974 – Unify hasTouchScrollableOverflow/needsCompositedScrolling concepts

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Frédéric Wang (:fredw)]

The following pattern is found in various places:

#if PLATFORM(IOS)
...hasTouchScrollableOverflow()...
#else
...needsCompositedScrolling()...
#endif

We can refactor the code to do that in one function.

@Simon: I don't know if we can merge these functions a bit further... It seems that to fix bug 149264 we would consider composited scrolling on iOS too?

[Frédéric Wang (:fredw)]

Created attachment 309716 [details]
Patch

[Michael Catanzaro]

Comment on attachment 309716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309716&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2191
> +bool RenderLayer::useCoordinatedScrolling() const

Would RenderLayer::usesCoordinatedScrolling be a better name for this?

[Frédéric Wang (:fredw)]

(In reply to Michael Catanzaro from comment #2)
> > Source/WebCore/rendering/RenderLayer.cpp:2191
> > +bool RenderLayer::useCoordinatedScrolling() const
> 
> Would RenderLayer::usesCoordinatedScrolling be a better name for this?

Right, I think it will be more consistent with the names of other member functions.

[Simon Fraser (smfr)]

Comment on attachment 309716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309716&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2191
>> +bool RenderLayer::useCoordinatedScrolling() const
> 
> Would RenderLayer::usesCoordinatedScrolling be a better name for this?

Yes!

Hopefully this won't be confused with coordinated graphics. Maybe "acceleratedScrolling"?

[Frédéric Wang (:fredw)]

Created attachment 309733 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309733 [details]
Patch

Rejecting attachment 309733 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 309733, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3719277

[Frédéric Wang (:fredw)]

Created attachment 309734 [details]
Patch

Setting correct reviewer...

[WebKit Commit Bot]

Comment on attachment 309734 [details]
Patch

Clearing flags on attachment: 309734

Committed r216688: <http://trac.webkit.org/changeset/216688>

[Frédéric Wang (:fredw)]

This is fixed.