Bug 171962 – Computing optionalDefArgWidth in CheckSpecial should not consider Scratch roles

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

I think we should be using isLateDef and not isAnyDef.

[Filip Pizlo]

(In reply to Saam Barati from comment #0)
> I think we should be using isLateDef and not isAnyDef.

I think it should be "Arg::isAnyDef(role) && role != Arg::Scratch".

The def that this code is looking for could be early or late.  The thing you're trying to ignore are Scratches, which aren't really defs for the purpose of this code.

[Saam Barati]

Created attachment 309756 [details]
patch

[WebKit Commit Bot]

Comment on attachment 309756 [details]
patch

Rejecting attachment 309756 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309756, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ingContext should implement WebGLRenderingContextBase
The copy of the patch that failed is found in:
   /Volumes/Data/EWS/WebKit/.git/rebase-apply/patch

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at /Volumes/Data/EWS/WebKit/Tools/Scripts/webkitdirs.pm line 2719.

Full output: http://webkit-queues.webkit.org/results/3721150

[WebKit Commit Bot]

Comment on attachment 309756 [details]
patch

Clearing flags on attachment: 309756

Committed r216734: <http://trac.webkit.org/changeset/216734>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.