Bug 171913 - Add an experimental feature flag for constant properties
Summary: Add an experimental feature flag for constant properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-10 00:36 PDT by Tim Horton
Modified: 2017-05-11 20:19 PDT (History)
7 users (show)

See Also:


Attachments
Patch (15.06 KB, patch)
2017-05-10 00:36 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (799.15 KB, application/zip)
2017-05-10 01:46 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.76 MB, application/zip)
2017-05-10 02:08 PDT, Build Bot
no flags Details
Patch (17.44 KB, patch)
2017-05-10 11:23 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-05-10 00:36:01 PDT
Add an experimental feature flag for constant properties
Comment 1 Tim Horton 2017-05-10 00:36:24 PDT
Created attachment 309583 [details]
Patch
Comment 2 Build Bot 2017-05-10 01:46:53 PDT
Comment on attachment 309583 [details]
Patch

Attachment 309583 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3710506

New failing tests:
fast/css/variables/constants/safe-area-inset-zero.html
fast/css/variables/constants/safe-area-inset-cannot-override.html
Comment 3 Build Bot 2017-05-10 01:46:55 PDT
Created attachment 309584 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-05-10 02:08:33 PDT
Comment on attachment 309583 [details]
Patch

Attachment 309583 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3710549

New failing tests:
fast/css/variables/constants/safe-area-inset-zero.html
fast/css/variables/constants/safe-area-inset-cannot-override.html
Comment 5 Build Bot 2017-05-10 02:08:35 PDT
Created attachment 309585 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Ryosuke Niwa 2017-05-10 02:12:17 PDT
Comment on attachment 309583 [details]
Patch

Please do fix the tests before landing.
Comment 7 Tim Horton 2017-05-10 10:15:50 PDT
Well, it's good that the tests failed :) I will fix them.
Comment 8 Tim Horton 2017-05-10 11:23:22 PDT
Created attachment 309620 [details]
Patch
Comment 9 Tim Horton 2017-05-10 13:27:40 PDT
https://trac.webkit.org/changeset/216611/webkit
Comment 10 Alexey Proskuryakov 2017-05-11 20:18:43 PDT
I'm never sure about how these settings work - are these reset between tests?
Comment 11 Ryosuke Niwa 2017-05-11 20:19:15 PDT
(In reply to Alexey Proskuryakov from comment #10)
> I'm never sure about how these settings work - are these reset between tests?

They're.