Bug 171912 - build-launcher-app doesn't make a functional app
Summary: build-launcher-app doesn't make a functional app
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified macOS 10.12
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-10 00:15 PDT by Patrick Quinn-Graham
Modified: 2017-05-11 20:16 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Quinn-Graham 2017-05-10 00:15:24 PDT 
If I run:

* build-webkit
* Tools/BuildSlaveSupport/build-launcher-app

The generated app doesn't launch - it is expecting WebKit.app/Contents/Frameworks/10.12/ to exists. Instead it puts some frameworks in WebKit.app/Contents/Resources/. Moving them to the Frameworks/10.12/ directory (and adding WebKitLegacy.framework) creates a usable nightly.

Obviously most users don't have a need to create their own nightly, but it'd be nice if this script functioned correctly, or at least the same as the one that produces the nightlies.

Of course I could be missing some other step (in which case, my bad! Sorry for wasting someones time reading this!)
Comment 1 Alexey Proskuryakov 2017-05-11 20:16:27 PDT 
Other parts of nightly building funtionality are also checked in, and I'm pretty sure that this script is expected to work in tandem with those, not on a local build. 

Perhaps this can be made more clear, suggestions are welcome!