Bug 171876 - REGRESSION(r213564): Flash audio playback failures
Summary: REGRESSION(r213564): Flash audio playback failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-09 12:24 PDT by Brent Fulgham
Modified: 2017-05-15 17:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2017-05-12 12:03 PDT, Brent Fulgham 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-05-09 12:24:36 PDT 
Some Flash audio playback stopped working after r213564. This was caused by a syntax error in the regular expression that should have resolved to IOAudioEngineDescription.

While reviewing these changes, I also discovered that "iokit-property" requires spaces to be escaped to get a proper match.

This patch corrects both problems.
Comment 1 Radar WebKit Bug Importer 2017-05-09 12:24:59 PDT 
<rdar://problem/32082745>
Comment 2 Brent Fulgham 2017-05-12 12:03:44 PDT 
Created attachment 309923 [details]
Patch
Comment 3 Brent Fulgham 2017-05-12 12:30:12 PDT 
(In reply to Brent Fulgham from comment #2)
> Created attachment 309923 [details]
> Patch

Note: After discussions with the Sandbox experts, I learned that it is NOT necessary to escape spaces in the sandbox rules.
Comment 4 Alexey Proskuryakov 2017-05-12 13:28:56 PDT 
Comment on attachment 309923 [details]
Patch

Unmaintainable.
Comment 5 Brent Fulgham 2017-05-12 13:43:04 PDT 
Committed r216790: <http://trac.webkit.org/changeset/216790>
Comment 6 Brent Fulgham 2017-05-15 17:50:54 PDT 
Note:

Follow-up fixed landed in:
Committed r216893: <http://trac.webkit.org/changeset/216893>