Bug 171850 – [GTK] Fix compile warnings in PlatformImageCairo.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Hyungwook Lee]

../../Tools/ImageDiff/cairo/PlatformImageCairo.cpp:53:42: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
             fread(data, 1, length, stdin);

[Hyungwook Lee]

Created attachment 309481 [details]
Patch

[Michael Catanzaro]

Comment on attachment 309481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309481&action=review

> Tools/ImageDiff/cairo/PlatformImageCairo.cpp:54
> +            return readBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR;

I would be stricter:

return readBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR;

Note that only works because the second parameter, size, is 1.

> Tools/ImageDiff/cairo/PlatformImageCairo.cpp:129
> +            return writtenBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR;

Ditto:

return writtenBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR;

[Hyungwook Lee]

Created attachment 309563 [details]
Patch

[Hyungwook Lee]

(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 309481 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309481&action=review
> 
> > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:54
> > +            return readBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR;
> 
> I would be stricter:
> 
> return readBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR;
> 
> Note that only works because the second parameter, size, is 1.
> 
> > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:129
> > +            return writtenBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR;
> 
> Ditto:
> 
> return writtenBytes == length ? CAIRO_STATUS_SUCCESS :
> CAIRO_STATUS_WRITE_ERROR;

Nice point, I've update the patch as you mentioned.

[Hyungwook Lee]

length

[WebKit Commit Bot]

Comment on attachment 309563 [details]
Patch

Clearing flags on attachment: 309563

Committed r216795: <http://trac.webkit.org/changeset/216795>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.