Bug 171846 – Drop custom bindings code for Window.location setter

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Drop custom code for Window.location setter.

The custom code was needed to fix a bug that was fixed a long time ago (rdar://problem/5695330).

[Chris Dumez]

Grumph. PutForwards currently does not work for window.location because DOMWindow::location() can currently return null and our bindings generator does not handle that.

We could add support in the bindings generator but I believe DOMWindow::location() is never supposed to return null. WebKit currently associates Location with the frame instead of the Window, which is not as per spec (and does not match Firefox or Chrome).

[Chris Dumez]

Created attachment 309514 [details]
Patch

[Sam Weinig]

Comment on attachment 309514 [details]
Patch

v.nice

[Sam Weinig]

(In reply to Chris Dumez from comment #1)
> Grumph. PutForwards currently does not work for window.location because
> DOMWindow::location() can currently return null and our bindings generator
> does not handle that.
> 
> We could add support in the bindings generator but I believe
> DOMWindow::location() is never supposed to return null. WebKit currently
> associates Location with the frame instead of the Window, which is not as
> per spec (and does not match Firefox or Chrome).

We really need to fix up our window/document/frame mess. It's long past due. (Do we rename Frame to BrowsingContext like madmen?)

[Chris Dumez]

Comment on attachment 309514 [details]
Patch

Clearing flags on attachment: 309514

Committed r216534: <http://trac.webkit.org/changeset/216534>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.