Update DocumentOrShadowRoot.idl to match specifications: - https://dom.spec.whatwg.org/#mixin-documentorshadowroot - https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin - https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin
Created attachment 309464 [details] Patch
Comment on attachment 309464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review > Source/WebCore/dom/Document.idl:106 > + // FIXME: Should likely be moved to DocumentOrShadowRoot. Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec.
Comment on attachment 309464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review >> Source/WebCore/dom/Document.idl:106 >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. Well, my issue is that https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin & https://drafts.csswg.org/cssom/#extensions-to-the-document-interface disagree.
(In reply to Chris Dumez from comment #3) > Comment on attachment 309464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309464&action=review > > >> Source/WebCore/dom/Document.idl:106 > >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. > > Well, my issue is that > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the- > documentorshadowroot-mixin & > https://drafts.csswg.org/cssom/#extensions-to-the-document-interface > disagree. Oh I see.
Comment on attachment 309464 [details] Patch Clearing flags on attachment: 309464 Committed r216506: <http://trac.webkit.org/changeset/216506>
All reviewed patches have been landed. Closing bug.