Bug 171833 – Web Inspector: Request/Response toggles not working

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Request/Response toggles not working

Steps to Reproduce:
1. Inspect https://bugreport.apple.com/
2. Login if needed (with a non-Apple account)
3. Select "Hidden" in the sidebar on the page
  => makes a getSectionProblems¹ resource
4. Select "Closed" in the sidebar on the page
  => makes a getSectionProblems² resource
5. Show Resource tab in Inspector
6. Select getSectionProblems¹
  => you are able to toggle between Request / Response just fine
7. Select getSectionProblems²
  => you cannot toggle between Request / Response

Notes:
- In step 7 the Request / Response toggles are actually for getSectionProblems¹
- The path components did not update because their "represented objects" didn't actually change, even though they are for a completely new object.
  See the bail in HierarchicalPathNavigationItem.js:

>    let componentsEqual = function(a, b) {
>        let getRepresentedObjects = (component) => component.representedObject;
>        let representedObjectsA = a.map(getRepresentedObjects);
>        let representedObjectsB = b.map(getRepresentedObjects);
>        return Array.shallowEqual(representedObjectsA, representedObjectsB);
>    };
>
>    if (this._components && componentsEqual(this._components, newComponents))
>        return;

[Joseph Pecoraro]

<rdar://problem/31341637>

[Joseph Pecoraro]

Created attachment 309422 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 309422 [details]
[PATCH] Proposed Fix

r=me!

[WebKit Commit Bot]

Comment on attachment 309422 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 309422

Committed r216461: <http://trac.webkit.org/changeset/216461>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.