Bug 171831 - Modernize WebKit2 code
Summary: Modernize WebKit2 code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-08 14:45 PDT by Alex Christensen
Modified: 2017-05-08 19:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (50.63 KB, patch)
2017-05-08 14:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (50.93 KB, patch)
2017-05-08 16:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (51.78 KB, patch)
2017-05-08 17:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-05-08 14:45:57 PDT 
Modernize WebKit2 code
Comment 1 Alex Christensen 2017-05-08 14:49:23 PDT 
Created attachment 309416 [details]
Patch
Comment 2 Chris Dumez 2017-05-08 14:54:33 PDT 
Comment on attachment 309416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review

r=me

> Source/WebKit2/UIProcess/WebPageProxy.cpp:3045
> +    Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable {

Could use auto no ?
Comment 3 Simon Fraser (smfr) 2017-05-08 14:55:02 PDT 
Comment on attachment 309416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309416&action=review

> Source/WebKit2/ChangeLog:3
> +        Modernize WebKit2 code

Modernize how? A bit more detail would be nice.
Comment 4 Alex Christensen 2017-05-08 16:12:50 PDT 
Created attachment 309434 [details]
Patch
Comment 5 Alex Christensen 2017-05-08 16:13:46 PDT 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 309416 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309416&action=review
> 
> r=me
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:3045
> > +    Function<void(CallbackBase::Error)> didForceRepaintCallback = [this, callback = WTFMove(callback)](CallbackBase::Error error) mutable {
> 
> Could use auto no ?
No, for some reason that causes a compiler error.  Something about constructors and lambdas and copies.
Comment 6 Alex Christensen 2017-05-08 17:24:57 PDT 
Created attachment 309445 [details]
Patch
Comment 7 Alex Christensen 2017-05-08 19:23:02 PDT 
http://trac.webkit.org/r216473