Bug 171824 - Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
Summary: Follow-up to bug 171710: use more references and reject if either audio or vi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 171849
  Show dependency tree / graph
 
Reported: 2017-05-08 13:27 PDT by youenn fablet
Modified: 2017-05-08 23:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (22.89 KB, patch)
2017-05-08 13:31 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Trying to fix GTK build (23.12 KB, patch)
2017-05-08 15:56 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Trying to fix GTK build 2 (23.72 KB, patch)
2017-05-08 16:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (23.56 KB, patch)
2017-05-08 21:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-08 13:27:37 PDT 
Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing
Comment 1 youenn fablet 2017-05-08 13:31:26 PDT 
Created attachment 309406 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-05-08 14:02:57 PDT 
<rdar://problem/32058957>
Comment 3 Eric Carlson 2017-05-08 14:18:41 PDT 
Comment on attachment 309406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59
> +        Vector<CaptureDevice> m_devices;

Where is this initialized?
Comment 4 youenn fablet 2017-05-08 14:23:10 PDT 
Comment on attachment 309406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review

>> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59
>> +        Vector<CaptureDevice> m_devices;
> 
> Where is this initialized?

It is empty currently.
We should probably add mock values and use them within tests.
Comment 5 youenn fablet 2017-05-08 15:56:57 PDT 
Created attachment 309423 [details]
Trying to fix GTK build
Comment 6 youenn fablet 2017-05-08 16:25:11 PDT 
Created attachment 309437 [details]
Trying to fix GTK build 2
Comment 7 Alex Christensen 2017-05-08 20:09:21 PDT 
Comment on attachment 309437 [details]
Trying to fix GTK build 2

View in context: https://bugs.webkit.org/attachment.cgi?id=309437&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:83
> +    return m_audioFactory ? *m_audioFactory: defaultAudioFactory();

space before colon
Comment 8 youenn fablet 2017-05-08 21:33:55 PDT 
Created attachment 309466 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2017-05-08 22:14:35 PDT 
Comment on attachment 309466 [details]
Patch for landing

Clearing flags on attachment: 309466

Committed r216477: <http://trac.webkit.org/changeset/216477>
Comment 10 WebKit Commit Bot 2017-05-08 22:14:37 PDT 
All reviewed patches have been landed.  Closing bug.