Bug 171824 – Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

Follow-up to bug 171710: use more references and reject if either audio or video source creation is failing

[youenn fablet]

Created attachment 309406 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/32058957>

[Eric Carlson]

Comment on attachment 309406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59
> +        Vector<CaptureDevice> m_devices;

Where is this initialized?

[youenn fablet]

Comment on attachment 309406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309406&action=review

>> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h:59
>> +        Vector<CaptureDevice> m_devices;
> 
> Where is this initialized?

It is empty currently.
We should probably add mock values and use them within tests.

[youenn fablet]

Created attachment 309423 [details]
Trying to fix GTK build

[youenn fablet]

Created attachment 309437 [details]
Trying to fix GTK build 2

[Alex Christensen]

Comment on attachment 309437 [details]
Trying to fix GTK build 2

View in context: https://bugs.webkit.org/attachment.cgi?id=309437&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:83
> +    return m_audioFactory ? *m_audioFactory: defaultAudioFactory();

space before colon

[youenn fablet]

Created attachment 309466 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 309466 [details]
Patch for landing

Clearing flags on attachment: 309466

Committed r216477: <http://trac.webkit.org/changeset/216477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.