Bug 171819 – Web Inspector: RTL: In Timelines > JavaScript & Events, digits for sample count are not localized

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Created attachment 309389 [details]
Screenshot - RTL

.

[Blaze Burg]

Created attachment 309431 [details]
Patch

[Blaze Burg]

Created attachment 309432 [details]
RTL - after

[Matt Baker]

Comment on attachment 309431 [details]
Patch

r=me

[Joseph Pecoraro]

Comment on attachment 309431 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309431&action=review

> Source/WebInspectorUI/UserInterface/Views/ScriptTimelineDataGridNode.js:153
>          case "callCount":
> -            return isNaN(value) ? emDash : value;
> +            return isNaN(value) ? emDash : value.toLocaleString();

Nice. Other places that sound like they would also apply are:

ResourceTimingDataGridNode.js: (statusCode and connectionIdentifier are both simple numbers)

        case "statusCode":
            cell.title = resource.statusText || "";
            return value || emDash;

        ...

        case "domain":
        case "method":
        case "scheme":
        case "protocol":
        case "remoteAddress":
        case "connectionIdentifier":
            if (value)
                cell.title = value;
            return value || emDash;

[Matt Baker]

Good catch!

[Build Bot]

Comment on attachment 309431 [details]
Patch

Attachment 309431 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3702001

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html

[Build Bot]

Created attachment 309446 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Blaze Burg]

Committed r217232: <http://trac.webkit.org/changeset/217232>