Bug 171816 - Remove black background from video layer while in fullscreen.
Summary: Remove black background from video layer while in fullscreen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-08 11:27 PDT by Jeremy Jones
Modified: 2017-11-02 11:37 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2017-05-08 11:30 PDT, Jeremy Jones 		eric.carlson: review+
Details | Formatted Diff | Diff
Alternate Patch. (1.76 KB, patch)
2017-05-08 13:54 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch for landing. (3.09 KB, patch)
2017-05-08 18:43 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-05-08 11:27:58 PDT 
Remove black background from video layer while in fullscreen.
Comment 1 Jeremy Jones 2017-05-08 11:28:49 PDT 
rdar://problem/31770423
Comment 2 Jeremy Jones 2017-05-08 11:30:52 PDT 
Created attachment 309385 [details]
Patch
Comment 3 Eric Carlson 2017-05-08 12:25:28 PDT 
Comment on attachment 309385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309385&action=review

We should have a test for this. You may be able to add a test for this to an existing API tests instead of writing a new test.

> Source/WebCore/ChangeLog:11
> +        and back to black when it returns to inline to better fascilitate fullsceen animations.

Nit: "fascilitate" => "facilitate"
Comment 4 Jeremy Jones 2017-05-08 13:54:33 PDT 
Created attachment 309407 [details]
Alternate Patch.
Comment 5 Jeremy Jones 2017-05-08 18:43:34 PDT 
Created attachment 309457 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2017-05-08 19:00:08 PDT 
Comment on attachment 309457 [details]
Patch for landing.

Clearing flags on attachment: 309457

Committed r216472: <http://trac.webkit.org/changeset/216472>