Bug 171815 - [iOS] Unset active media capture source when stopped capturing
Summary: [iOS] Unset active media capture source when stopped capturing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-08 11:24 PDT by youenn fablet
Modified: 2017-05-11 17:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.36 KB, patch)
2017-05-08 11:28 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2017-05-08 12:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (11.49 MB, application/zip)
2017-05-08 14:05 PDT, Build Bot
no flags Details
Patch (14.87 KB, patch)
2017-05-08 14:37 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (15.73 KB, patch)
2017-05-08 14:38 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (849.03 KB, application/zip)
2017-05-08 16:49 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (6.84 MB, application/zip)
2017-05-08 18:01 PDT, Build Bot
no flags Details
Patch (36.18 KB, patch)
2017-05-10 14:33 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.07 MB, application/zip)
2017-05-10 15:35 PDT, Build Bot
no flags Details
Patch (44.25 KB, patch)
2017-05-10 16:23 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.29 MB, application/zip)
2017-05-10 17:42 PDT, Build Bot
no flags Details
Patch (46.20 KB, patch)
2017-05-10 18:19 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.61 MB, application/zip)
2017-05-10 19:50 PDT, Build Bot
no flags Details
Patch for landing (46.24 KB, patch)
2017-05-11 17:09 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-08 11:24:28 PDT
on iOS, we keep only one active capture source at a time.
When the source is stopped, it should not stay as the factory active source.
Comment 1 youenn fablet 2017-05-08 11:28:15 PDT
Created attachment 309383 [details]
Patch
Comment 2 youenn fablet 2017-05-08 12:43:16 PDT
Created attachment 309396 [details]
Patch
Comment 3 Build Bot 2017-05-08 14:05:35 PDT
Comment on attachment 309396 [details]
Patch

Attachment 309396 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3700756

New failing tests:
webrtc/audio-replace-track.html
Comment 4 Build Bot 2017-05-08 14:05:36 PDT
Created attachment 309408 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 youenn fablet 2017-05-08 14:37:56 PDT
Created attachment 309412 [details]
Patch
Comment 6 youenn fablet 2017-05-08 14:38:19 PDT
Created attachment 309413 [details]
Patch
Comment 7 Build Bot 2017-05-08 16:49:10 PDT
Comment on attachment 309413 [details]
Patch

Attachment 309413 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3701492

New failing tests:
webrtc/audio-replace-track.html
Comment 8 Build Bot 2017-05-08 16:49:12 PDT
Created attachment 309440 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-05-08 18:01:33 PDT
Comment on attachment 309413 [details]
Patch

Attachment 309413 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3702097

New failing tests:
webrtc/audio-replace-track.html
Comment 10 Build Bot 2017-05-08 18:01:34 PDT
Created attachment 309451 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 youenn fablet 2017-05-10 14:33:27 PDT
Created attachment 309636 [details]
Patch
Comment 12 Radar WebKit Bug Importer 2017-05-10 14:36:07 PDT
<rdar://problem/32117885>
Comment 13 Build Bot 2017-05-10 15:35:26 PDT
Comment on attachment 309636 [details]
Patch

Attachment 309636 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3714061

New failing tests:
webrtc/video-replace-track.html
Comment 14 Build Bot 2017-05-10 15:35:27 PDT
Created attachment 309648 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 15 youenn fablet 2017-05-10 16:23:09 PDT
Created attachment 309655 [details]
Patch
Comment 16 Build Bot 2017-05-10 17:42:08 PDT
Comment on attachment 309655 [details]
Patch

Attachment 309655 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3714631

New failing tests:
webrtc/video-replace-track.html
Comment 17 Build Bot 2017-05-10 17:42:10 PDT
Created attachment 309663 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 18 youenn fablet 2017-05-10 18:19:40 PDT
Created attachment 309670 [details]
Patch
Comment 19 Build Bot 2017-05-10 19:50:37 PDT
Comment on attachment 309670 [details]
Patch

Attachment 309670 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3715172

New failing tests:
fast/dom/Window/slow-unload-handler-overwritten-date.html
Comment 20 Build Bot 2017-05-10 19:50:39 PDT
Created attachment 309677 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 21 youenn fablet 2017-05-11 10:04:16 PDT
(In reply to Build Bot from comment #19)
> Comment on attachment 309670 [details]
> Patch
> 
> Attachment 309670 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3715172
> 
> New failing tests:
> fast/dom/Window/slow-unload-handler-overwritten-date.html

Failure is unrelated
Comment 22 Eric Carlson 2017-05-11 14:14:46 PDT
Comment on attachment 309670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309670&action=review

> Source/WebCore/ChangeLog:15
> +        Updating all capture sources accordingly.
> +        Ensuring sources are no longer considered as active sources when being destroyed.
> +        Adding support for mock sources and introducing m_isProducingData for them as well.

Nit: "Updating" => "Update", "Ensuring" => "Ensure", "Adding" => "Add"

> Source/WebCore/ChangeLog:21
> +        Updating WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
> +        state according the new source.
> +
> +        Updating the way we handle timestamps for audio data. We now consider that we read/write as a flow.
> +        This allows smooth audio track replacing.

Nit: "Updating"
Comment 23 youenn fablet 2017-05-11 17:09:05 PDT
Created attachment 309828 [details]
Patch for landing
Comment 24 youenn fablet 2017-05-11 17:09:32 PDT
Thanks for the review.

> > Source/WebCore/ChangeLog:15
> > +        Updating all capture sources accordingly.
> > +        Ensuring sources are no longer considered as active sources when being destroyed.
> > +        Adding support for mock sources and introducing m_isProducingData for them as well.
> 
> Nit: "Updating" => "Update", "Ensuring" => "Ensure", "Adding" => "Add"

Done

> > Source/WebCore/ChangeLog:21
> > +        Updating WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
> > +        state according the new source.
> > +
> > +        Updating the way we handle timestamps for audio data. We now consider that we read/write as a flow.
> > +        This allows smooth audio track replacing.
> 
> Nit: "Updating"

Done
Comment 25 WebKit Commit Bot 2017-05-11 17:52:48 PDT
Comment on attachment 309828 [details]
Patch for landing

Clearing flags on attachment: 309828

Committed r216712: <http://trac.webkit.org/changeset/216712>
Comment 26 WebKit Commit Bot 2017-05-11 17:52:50 PDT
All reviewed patches have been landed.  Closing bug.