Bug 171815 – [iOS] Unset active media capture source when stopped capturing

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

on iOS, we keep only one active capture source at a time.
When the source is stopped, it should not stay as the factory active source.

[youenn fablet]

Created attachment 309383 [details]
Patch

[youenn fablet]

Created attachment 309396 [details]
Patch

[Build Bot]

Comment on attachment 309396 [details]
Patch

Attachment 309396 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3700756

New failing tests:
webrtc/audio-replace-track.html

[Build Bot]

Created attachment 309408 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 309412 [details]
Patch

[youenn fablet]

Created attachment 309413 [details]
Patch

[Build Bot]

Comment on attachment 309413 [details]
Patch

Attachment 309413 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3701492

New failing tests:
webrtc/audio-replace-track.html

[Build Bot]

Created attachment 309440 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 309413 [details]
Patch

Attachment 309413 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3702097

New failing tests:
webrtc/audio-replace-track.html

[Build Bot]

Created attachment 309451 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 309636 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/32117885>

[Build Bot]

Comment on attachment 309636 [details]
Patch

Attachment 309636 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3714061

New failing tests:
webrtc/video-replace-track.html

[Build Bot]

Created attachment 309648 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 309655 [details]
Patch

[Build Bot]

Comment on attachment 309655 [details]
Patch

Attachment 309655 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3714631

New failing tests:
webrtc/video-replace-track.html

[Build Bot]

Created attachment 309663 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 309670 [details]
Patch

[Build Bot]

Comment on attachment 309670 [details]
Patch

Attachment 309670 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3715172

New failing tests:
fast/dom/Window/slow-unload-handler-overwritten-date.html

[Build Bot]

Created attachment 309677 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[youenn fablet]

(In reply to Build Bot from comment #19)
> Comment on attachment 309670 [details]
> Patch
> 
> Attachment 309670 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/3715172
> 
> New failing tests:
> fast/dom/Window/slow-unload-handler-overwritten-date.html

Failure is unrelated

[Eric Carlson]

Comment on attachment 309670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309670&action=review

> Source/WebCore/ChangeLog:15
> +        Updating all capture sources accordingly.
> +        Ensuring sources are no longer considered as active sources when being destroyed.
> +        Adding support for mock sources and introducing m_isProducingData for them as well.

Nit: "Updating" => "Update", "Ensuring" => "Ensure", "Adding" => "Add"

> Source/WebCore/ChangeLog:21
> +        Updating WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
> +        state according the new source.
> +
> +        Updating the way we handle timestamps for audio data. We now consider that we read/write as a flow.
> +        This allows smooth audio track replacing.

Nit: "Updating"

[youenn fablet]

Created attachment 309828 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

> > Source/WebCore/ChangeLog:15
> > +        Updating all capture sources accordingly.
> > +        Ensuring sources are no longer considered as active sources when being destroyed.
> > +        Adding support for mock sources and introducing m_isProducingData for them as well.
> 
> Nit: "Updating" => "Update", "Ensuring" => "Ensure", "Adding" => "Add"

Done

> > Source/WebCore/ChangeLog:21
> > +        Updating WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
> > +        state according the new source.
> > +
> > +        Updating the way we handle timestamps for audio data. We now consider that we read/write as a flow.
> > +        This allows smooth audio track replacing.
> 
> Nit: "Updating"

Done

[WebKit Commit Bot]

Comment on attachment 309828 [details]
Patch for landing

Clearing flags on attachment: 309828

Committed r216712: <http://trac.webkit.org/changeset/216712>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.