Bug 171813 - Drop [CEReactions] from CharacterData operations
Summary: Drop [CEReactions] from CharacterData operations
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Depends on: 171688
Blocks: 154907
  Show dependency treegraph
Reported: 2017-05-08 10:34 PDT by Chris Dumez
Modified: 2017-05-08 19:46 PDT (History)
13 users (show)

See Also:

Patch (2.82 KB, patch)
2017-05-08 12:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-08 10:34:55 PDT
Drop [CEReactions] from CharacterData operations to match the DOM specification:
- https://dom.spec.whatwg.org/#interface-characterdata

I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying those Text child nodes via the CharacterData API could modify the value of an attribute, requiring us to run attributeChangedCallback for Custom Elements. However, as of Bug 171688, Attr can no longer have Text child nodes.

I have also verified that Blink does not have [CEReactions] for those methods.
Comment 1 Chris Dumez 2017-05-08 12:18:13 PDT
Created attachment 309393 [details]
Comment 2 WebKit Commit Bot 2017-05-08 19:46:29 PDT
Comment on attachment 309393 [details]

Clearing flags on attachment: 309393

Committed r216474: <http://trac.webkit.org/changeset/216474>
Comment 3 WebKit Commit Bot 2017-05-08 19:46:31 PDT
All reviewed patches have been landed.  Closing bug.