WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 171813
Drop [CEReactions] from CharacterData operations
https://bugs.webkit.org/show_bug.cgi?id=171813
Summary
Drop [CEReactions] from CharacterData operations
Chris Dumez
Reported
2017-05-08 10:34:55 PDT
Drop [CEReactions] from CharacterData operations to match the DOM specification: -
https://dom.spec.whatwg.org/#interface-characterdata
I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying those Text child nodes via the CharacterData API could modify the value of an attribute, requiring us to run attributeChangedCallback for Custom Elements. However, as of
Bug 171688
, Attr can no longer have Text child nodes. I have also verified that Blink does not have [CEReactions] for those methods.
Attachments
Patch
(2.82 KB, patch)
2017-05-08 12:18 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2017-05-08 12:18:13 PDT
Created
attachment 309393
[details]
Patch
WebKit Commit Bot
Comment 2
2017-05-08 19:46:29 PDT
Comment on
attachment 309393
[details]
Patch Clearing flags on attachment: 309393 Committed
r216474
: <
http://trac.webkit.org/changeset/216474
>
WebKit Commit Bot
Comment 3
2017-05-08 19:46:31 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug