Bug 171812 - CoreAudioSharedUnit should own its configuration parameters
Summary: CoreAudioSharedUnit should own its configuration parameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-08 10:32 PDT by youenn fablet
Modified: 2017-05-08 15:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2017-05-08 10:40 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (10.71 KB, patch)
2017-05-08 10:56 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (10.69 KB, patch)
2017-05-08 14:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-08 10:32:45 PDT
Currently, it takes its parameters (sampleRate, echoCancellation...) from its first client.
But it should really be the last client having either been created or been applying constraints.
Comment 1 youenn fablet 2017-05-08 10:40:09 PDT
Created attachment 309377 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-05-08 10:51:34 PDT
<rdar://problem/32053243>
Comment 3 Build Bot 2017-05-08 10:53:44 PDT
Attachment 309377 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:253:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2017-05-08 10:56:00 PDT
Created attachment 309380 [details]
Patch
Comment 5 Eric Carlson 2017-05-08 12:22:58 PDT
Comment on attachment 309380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309380&action=review

> Source/WebCore/ChangeLog:11
> +        Adding sampleRate, volume and echoCancellation parameters to the shared audio unit.
> +        Setting default values when creating the shared audio unit and using those for the creation of new sources.

Nit: "Adding" => "Add", "Setting" => "Set", "using" => "use"

> Source/WebCore/ChangeLog:14
> +        Checking valid sample rates when trying to apply a sample rate.

Nit: "Checking" => "Check"
Comment 6 youenn fablet 2017-05-08 14:43:05 PDT
Created attachment 309414 [details]
Patch
Comment 7 WebKit Commit Bot 2017-05-08 15:12:42 PDT
Comment on attachment 309414 [details]
Patch

Clearing flags on attachment: 309414

Committed r216455: <http://trac.webkit.org/changeset/216455>
Comment 8 WebKit Commit Bot 2017-05-08 15:12:44 PDT
All reviewed patches have been landed.  Closing bug.