Bug 171809 – Reduce PassRefPtr use

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Reduce PassRefPtr use

[Alex Christensen]

Created attachment 309368 [details]
Patch

[Build Bot]

Attachment 309368 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 309368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309368&action=review

r=me with comments, please make sure all bots are happy.

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:355
> +        AVPlayerLayer *destinationPlayerLayer = static_cast<PlatformCALayerCocoa&>(newLayer.get()).avPlayerLayer();

Should be a downcast.

> Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp:54
>      visitedLinkTableControllerPtr = visitedLinkTableController.ptr();

This line seems useless?

> Source/WebKit2/WebProcess/WebPage/WebOpenPanelResultListener.h:57
>      RefPtr<WebCore::FileChooser> m_fileChooser;

Should be a Ref<>.

[Alex Christensen]

Created attachment 309371 [details]
Patch

[Chris Dumez]

Comment on attachment 309371 [details]
Patch

Same comments as before.

[Alex Christensen]

(In reply to Chris Dumez from comment #3)
> > Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:355
> > +        AVPlayerLayer *destinationPlayerLayer = static_cast<PlatformCALayerCocoa&>(newLayer.get()).avPlayerLayer();
> 
> Should be a downcast.
That doesn't compile.
> 
> > Source/WebKit2/WebProcess/WebPage/VisitedLinkTableController.cpp:54
> >      visitedLinkTableControllerPtr = visitedLinkTableController.ptr();
> 
> This line seems useless?
It's needed in this case to set the pointer in the HashMap.  Weird.  We can't use ensure here, though, because the HashMap values are raw pointers, and we need to return a Ref here.

[Alex Christensen]

Created attachment 309378 [details]
Patch

[Alex Christensen]

Created attachment 309384 [details]
Patch

[Alex Christensen]

Created attachment 309386 [details]
Patch

[Alex Christensen]

Created attachment 309392 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r216448