RESOLVED FIXED 171807
[css-grid] Remove Blink-specific code for handling orthogonal grid items 
https://bugs.webkit.org/show_bug.cgi?id=171807
Summary [css-grid] Remove Blink-specific code for handling orthogonal grid items
Sergio Villar Senin
Reported 2017-05-08 09:21:09 PDT
[css-grid] Remove Blink-specific code for handling orthogonal grid items
Attachments
Patch (16.32 KB, patch)
2017-05-08 09:28 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2017-05-08 09:28:31 PDT
Created attachment 309365 [details] Patch
Sergio Villar Senin
Comment 2 2017-05-10 00:42:53 PDT
Committed r216574: <http://trac.webkit.org/changeset/216574>
Javier Fernandez
Comment 3 2017-05-10 07:28:49 PDT
Comment on attachment 309365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309365&action=review > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:-763 > - Even that the comment is confusing, because it mentions the pre-layout stuff that blink is doing on orthogonal flow boxes, the removed code had a different purpose. It was not only there to avoid further computation, but it's main goal was to avoid performing layouts during the intrinsic size computation. Now that these lines are gone, in case of computing column tracks based on orthogonal grid items size, we will use logicalHeightForChild, which will indeed laid out the grid item to figure out its actual size. > Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:772 > } Ditto
Note You need to log in before you can comment on or make changes to this bug.