Bug 171799 - WebAssembly: don't just emit extended offset adds for patch
Summary: WebAssembly: don't just emit extended offset adds for patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on: 170215
Blocks: 159775
  Show dependency treegraph
 
Reported: 2017-05-07 22:41 PDT by JF Bastien
Modified: 2017-05-08 10:06 PDT (History)
7 users (show)

See Also:


Attachments
patch (2.19 KB, patch)
2017-05-07 22:43 PDT, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-05-07 22:41:15 PDT
As recommended by pizlo in bug #170215.
Comment 1 JF Bastien 2017-05-07 22:43:38 PDT
Created attachment 309346 [details]
patch

pizlo had said:

(In reply to Filip Pizlo from comment #30)
> Comment on attachment 309022 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309022&action=review
> 
> > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80
> > +                        if (isPatch && inst.admitsExtendedOffsetAddr(arg)) {
> 
> I would drop the isPatch check
Comment 2 Mark Lam 2017-05-08 09:31:58 PDT
Comment on attachment 309346 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2017-05-08 10:06:32 PDT
Comment on attachment 309346 [details]
patch

Clearing flags on attachment: 309346

Committed r216430: <http://trac.webkit.org/changeset/216430>
Comment 4 WebKit Commit Bot 2017-05-08 10:06:35 PDT
All reviewed patches have been landed.  Closing bug.