RESOLVED FIXED 171799
WebAssembly: don't just emit extended offset adds for patch 
https://bugs.webkit.org/show_bug.cgi?id=171799
Summary WebAssembly: don't just emit extended offset adds for patch
JF Bastien
Reported 2017-05-07 22:41:15 PDT
As recommended by pizlo in bug #170215.
Attachments
patch (2.19 KB, patch)
2017-05-07 22:43 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-05-07 22:43:38 PDT
Created attachment 309346 [details] patch pizlo had said: (In reply to Filip Pizlo from comment #30) > Comment on attachment 309022 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309022&action=review > > > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80 > > + if (isPatch && inst.admitsExtendedOffsetAddr(arg)) { > > I would drop the isPatch check
Mark Lam
Comment 2 2017-05-08 09:31:58 PDT
Comment on attachment 309346 [details] patch r=me
WebKit Commit Bot
Comment 3 2017-05-08 10:06:32 PDT
Comment on attachment 309346 [details] patch Clearing flags on attachment: 309346 Committed r216430: <http://trac.webkit.org/changeset/216430>
WebKit Commit Bot
Comment 4 2017-05-08 10:06:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.