Bug 171795 – Move 'style' from Element to HTMLElement / SVGElement and make it settable

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Move 'style' from Element to HTMLElement / SVGElement and make it settable, as per:
- https://drafts.csswg.org/cssom/#the-elementcssinlinestyle-interface

Both Firefox and Chrome already follow the specification.

[Chris Dumez]

Created attachment 309335 [details]
WIP patch

[Build Bot]

Attachment 309335 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:138:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 309336 [details]
WIP patch

[Chris Dumez]

Created attachment 309337 [details]
Patch

[Chris Dumez]

Created attachment 309339 [details]
Patch

[Chris Dumez]

Created attachment 309340 [details]
Patch

[Chris Dumez]

Created attachment 309343 [details]
Patch

[Alex Christensen]

Comment on attachment 309343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309343&action=review

> Source/WebCore/css/StyleProperties.cpp:1335
>      m_cssomWrapper = std::make_unique<PropertySetCSSStyleDeclaration>(this);

*this

[Chris Dumez]

Created attachment 309362 [details]
Patch

[Chris Dumez]

Comment on attachment 309362 [details]
Patch

Clearing flags on attachment: 309362

Committed r216426: <http://trac.webkit.org/changeset/216426>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.