Bug 171795 - Move 'style' from Element to HTMLElement / SVGElement and make it settable
Summary: Move 'style' from Element to HTMLElement / SVGElement and make it settable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://drafts.csswg.org/cssom/#the-e...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2017-05-07 16:44 PDT by Chris Dumez
Modified: 2017-06-07 15:50 PDT (History)
6 users (show)

See Also:

Attachments
WIP patch (34.37 KB, patch)
2017-05-07 17:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP patch (38.04 KB, patch)
2017-05-07 18:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (46.37 KB, patch)
2017-05-07 18:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (51.48 KB, patch)
2017-05-07 19:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (51.12 KB, patch)
2017-05-07 19:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (52.71 KB, patch)
2017-05-07 21:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (54.04 KB, patch)
2017-05-08 08:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-07 16:44:17 PDT 
Move 'style' from Element to HTMLElement / SVGElement and make it settable, as per:
- https://drafts.csswg.org/cssom/#the-elementcssinlinestyle-interface

Both Firefox and Chrome already follow the specification.
Comment 1 Chris Dumez 2017-05-07 17:59:50 PDT 
Created attachment 309335 [details]
WIP patch
Comment 2 Build Bot 2017-05-07 18:02:11 PDT 
Attachment 309335 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:138:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2017-05-07 18:30:00 PDT 
Created attachment 309336 [details]
WIP patch
Comment 4 Chris Dumez 2017-05-07 18:42:47 PDT 
Created attachment 309337 [details]
Patch
Comment 5 Chris Dumez 2017-05-07 19:30:34 PDT 
Created attachment 309339 [details]
Patch
Comment 6 Chris Dumez 2017-05-07 19:32:46 PDT 
Created attachment 309340 [details]
Patch
Comment 7 Chris Dumez 2017-05-07 21:35:35 PDT 
Created attachment 309343 [details]
Patch
Comment 8 Alex Christensen 2017-05-08 04:44:40 PDT 
Comment on attachment 309343 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309343&action=review

> Source/WebCore/css/StyleProperties.cpp:1335
>      m_cssomWrapper = std::make_unique<PropertySetCSSStyleDeclaration>(this);

*this
Comment 9 Chris Dumez 2017-05-08 08:48:09 PDT 
Created attachment 309362 [details]
Patch
Comment 10 Chris Dumez 2017-05-08 09:50:50 PDT 
Comment on attachment 309362 [details]
Patch

Clearing flags on attachment: 309362

Committed r216426: <http://trac.webkit.org/changeset/216426>
Comment 11 Chris Dumez 2017-05-08 09:50:52 PDT 
All reviewed patches have been landed.  Closing bug.