Bug 171784 – fast/shadow-dom/link-element-in-shadow-tree.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

@@ -1,5 +1,5 @@
 
-PASS Link elements should load stylesheets inside a connected shadow tree with closed mode 
+FAIL Link elements should load stylesheets inside a connected shadow tree with closed mode promise_test: Unhandled rejection with value: "timeout"
 PASS Link elements should load stylesheets inside a connected shadow tree with open mode 
 PASS Link elements must not load stylesheets inside a disconnceted shadow tree with closed mode 
 PASS Link elements must not load stylesheets inside a disconnceted shadow tree with open mode

[Truitt Savell]

This same failure still appears to happen.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fshadow-dom%2Flink-element-in-shadow-tree.html

The diff is the exact same.

[Radar WebKit Bug Importer]

<rdar://problem/58123584>

[Truitt Savell]

History shows this flakiness became a lot worse recently around r253500

[Truitt Savell]

marked test as failing in https://trac.webkit.org/changeset/253843/webkit

[Ryosuke Niwa]

Hm... I can't reproduce this with:
./Tools/Scripts/run-webkit-tests --debug fast/shadow-dom/link-element-in-shadow-tree.html --iterations 100 --exit-after-n-failures=1 --no-show-results

[Ryosuke Niwa]

Created attachment 387626 [details]
Fixes the test

[Antti Koivisto]

Comment on attachment 387626 [details]
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=387626&action=review

> LayoutTests/ChangeLog:10
> +        Load and cache the styleshe before any test cases run to avoid this timeout.

stylesheet

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #7)
> Comment on attachment 387626 [details]
> Fixes the test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387626&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        Load and cache the styleshe before any test cases run to avoid this timeout.
> 
> stylesheet

Oops, fixed.

[Ryosuke Niwa]

Oops, also forgot to remove the flaky test expectation. Doing that in the same patch.

[Ryosuke Niwa]

This isn't really a regression. As far as I can tell, this test had already been flaky.

[Ryosuke Niwa]

Committed r254546: <https://trac.webkit.org/changeset/254546>

[Ryosuke Niwa]

The test appears to be no longer flaky.

[Alexey Proskuryakov]

I do not concur.

On open source bots, the test stopped failing even before this fix. On internal ones, I see failures even after the fix.


 PASS Link elements must not load stylesheets inside a disconnceted shadow tree with open mode 
 PASS Style rules loaded inside a shadow tree with closed mode must apply to a div in the shadow tree 
 PASS Style rules loaded inside a shadow tree with open mode must apply to a div in the shadow tree 
-PASS :host style rules loaded inside a shadow tree with closed mode must apply to the host element 
+FAIL :host style rules loaded inside a shadow tree with closed mode must apply to the host element promise_test: Unhandled rejection with value: "timeout"
 PASS :host style rules loaded inside a shadow tree with open mode must apply to the host element

[Alexey Proskuryakov]

Not sure if it's best to reopen or to have a new bug for a new fix in this case.

And thank you for following up after landing the fix!

[Ryosuke Niwa]

(In reply to Alexey Proskuryakov from comment #14)
> Not sure if it's best to reopen or to have a new bug for a new fix in this
> case.
> 
> And thank you for following up after landing the fix!

Oh, interesting. Maybe you can file a radar for the internal failure. I can follow up on that there.

[Alexey Proskuryakov]

Filed rdar://problem/58713068