171779 – Reduce the number of includes in WebPage.h and WebProcess.h

Bug 171779 - Reduce the number of includes in WebPage.h and WebProcess.h

Summary: Reduce the number of includes in WebPage.h and WebProcess.h

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Tim Horton

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-05-06 16:22 PDT by Tim Horton
Modified:	2017-05-07 12:50 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (15.90 KB, patch) 2017-05-06 16:23 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (15.81 KB, patch) 2017-05-06 16:29 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (16.41 KB, patch) 2017-05-06 16:34 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (16.97 KB, patch) 2017-05-06 16:37 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (17.22 KB, patch) 2017-05-06 16:40 PDT, Tim Horton	no flags	Details \| Formatted Diff \| Diff
Patch (17.22 KB, patch) 2017-05-06 16:46 PDT, Tim Horton	sam: review+	Details \| Formatted Diff \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Horton 2017-05-06 16:22:51 PDT

Reduce the number of includes in WebPage.h and WebProcess.h

Comment 1 Tim Horton 2017-05-06 16:23:10 PDT

Created attachment 309302 [details]
Patch

Comment 2 Tim Horton 2017-05-06 16:27:46 PDT

There's ... a lot more low hanging fruit (it's probably more valuable to look at WebCore). I'm hacking together some scripts to help identify valuable candidates.

Comment 3 Tim Horton 2017-05-06 16:29:42 PDT

Created attachment 309303 [details]
Patch

Comment 4 Tim Horton 2017-05-06 16:34:25 PDT

Created attachment 309304 [details]
Patch

Comment 5 Tim Horton 2017-05-06 16:37:01 PDT

Created attachment 309306 [details]
Patch

Comment 6 Tim Horton 2017-05-06 16:37:27 PDT

Clearly another important part of doing this is going to be having a Gtk build set up :|

Comment 7 Tim Horton 2017-05-06 16:40:11 PDT

Created attachment 309308 [details]
Patch

Comment 8 Tim Horton 2017-05-06 16:46:32 PDT

Created attachment 309309 [details]
Patch

Comment 9 Tim Horton 2017-05-06 20:25:51 PDT

https://trac.webkit.org/changeset/216338/webkit

Comment 10 Michael Catanzaro 2017-05-07 12:50:56 PDT

Nice!