Bug 171778 - [iOS WK2] Make rotation tests more reliable
Summary: [iOS WK2] Make rotation tests more reliable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-06 15:49 PDT by Simon Fraser (smfr)
Modified: 2017-05-06 19:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (14.39 KB, patch)
2017-05-06 15:54 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-05-06 15:49:04 PDT 
[iOS WK2] Make rotation tests more reliable
Comment 1 Simon Fraser (smfr) 2017-05-06 15:54:42 PDT 
Created attachment 309301 [details]
Patch
Comment 2 Build Bot 2017-05-06 15:57:26 PDT 
Attachment 309301 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/ios/TestControllerIOS.mm:102:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Tools/WebKitTestRunner/ios/TestControllerIOS.mm:114:  No space between ^ and block definition.  [whitespace/brackets] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2017-05-06 19:54:36 PDT 
https://webkit.org/b/171778
Comment 4 Simon Fraser (smfr) 2017-05-06 19:55:33 PDT 
https://trac.webkit.org/r216335