Bug 171766 - Remove Vibration API
Summary: Remove Vibration API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Depends on:
Reported: 2017-05-05 19:09 PDT by Joseph Pecoraro
Modified: 2017-05-11 14:46 PDT (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (61.48 KB, patch)
2017-05-05 19:11 PDT, Joseph Pecoraro
ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.68 MB, application/zip)
2017-05-06 00:39 PDT, Build Bot
no flags Details
[PATCH] For Bots (61.95 KB, patch)
2017-05-09 11:49 PDT, Joseph Pecoraro
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-05-05 19:09:03 PDT
Remove Vibration API

- Not enabled by any ports
- Tests are skipped by all ports
- Unmaintained code
Comment 1 Joseph Pecoraro 2017-05-05 19:11:19 PDT
Created attachment 309258 [details]
[PATCH] Proposed Fix

I'll let the bots chew on this as well as a local build.

Perhaps we should run this by webkit-dev?
Comment 2 Alexey Proskuryakov 2017-05-05 21:32:54 PDT
Comment on attachment 309258 [details]
[PATCH] Proposed Fix

Perhaps. rs=me anyway.
Comment 3 Build Bot 2017-05-06 00:39:53 PDT
Comment on attachment 309258 [details]
[PATCH] Proposed Fix

Attachment 309258 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3685229

New failing tests:
Comment 4 Build Bot 2017-05-06 00:39:54 PDT
Created attachment 309277 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Joseph Pecoraro 2017-05-09 11:36:49 PDT
Now needs:

    23:Bug(WPE) vibration/ [ Skip ]
Comment 6 Joseph Pecoraro 2017-05-09 11:40:21 PDT
Started a webkit-dev thread:
Comment 7 Joseph Pecoraro 2017-05-09 11:49:10 PDT
Created attachment 309518 [details]
[PATCH] For Bots
Comment 8 WebKit Commit Bot 2017-05-11 14:27:24 PDT
Comment on attachment 309518 [details]
[PATCH] For Bots

Rejecting attachment 309518 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 309518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
r is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
 + a523d35...5a6ab82 master     -> origin/master  (forced update)
Current branch master is up to date.
Total errors found: 0 in 1 files

Full output: http://webkit-queues.webkit.org/results/3720821
Comment 9 Joseph Pecoraro 2017-05-11 14:46:19 PDT