RESOLVED FIXED 171755
Make it possible to test rotation in iOS WebKitTestRunner 
https://bugs.webkit.org/show_bug.cgi?id=171755
Summary Make it possible to test rotation in iOS WebKitTestRunner
Simon Fraser (smfr)
Reported 2017-05-05 15:49:55 PDT
Make it possible to test rotation in iOS WebKitTestRunner
Attachments
Patch (27.62 KB, patch)
2017-05-05 16:05 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-05-05 16:05:29 PDT
Created attachment 309231 [details] Patch
Radar WebKit Bug Importer
Comment 2 2017-05-05 16:05:50 PDT
<rdar://problem/32028012>
Build Bot
Comment 3 2017-05-05 16:07:42 PDT
Attachment 309231 [details] did not pass style-queue: ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:46: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:49: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:52: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp:55: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:122: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:127: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:137: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:40: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/ios/UIKitSPI.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:558: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:582: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:598: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 13 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2017-05-05 16:19:27 PDT
Comment on attachment 309231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309231&action=review > LayoutTests/fast/events/ios/rotation/basic-rotation-expected.txt:10 > +PASS window.innerWidth is 320 > +PASS window.innerHeight is 320 Please check these in as failures.
Simon Fraser (smfr)
Comment 5 2017-05-05 16:40:27 PDT
https://trac.webkit.org/r216291
Note You need to log in before you can comment on or make changes to this bug.