Bug 171742 – [iOS Simulator] Flaky failure LayoutTest/webrtc/libwebrtc/release-while-setting-local-description.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Matt Lewis]

The test webrtc/libwebrtc/release-while-setting-local-description.html is a flaky failure.

This test has been flaky since r215916:
https://trac.webkit.org/changeset/215916/webkit

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Flibwebrtc%2Frelease-while-setting-local-description.html

Build log:
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/builds/1113

Diff:
--- /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/release-while-setting-local-description-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-debug-tests-wk2/build/layout-test-results/webrtc/libwebrtc/release-while-setting-local-description-actual.txt
@@ -1,5 +1,4 @@
 CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Argument 1 ('candidate') to RTCPeerConnection.addIceCandidate must be an instance of RTCIceCandidate
-CONSOLE MESSAGE: Unhandled Promise Rejection: InvalidStateError (DOM Exception 11): The object is in an invalid state.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Joseph Pecoraro]

This looks like it is our own test? I'd suggest the test handle possible promise exceptions.

[Ryan Haddad]

Created attachment 309226 [details]
Patch

[Build Bot]

Comment on attachment 309226 [details]
Patch

Attachment 309226 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3681795

New failing tests:
webrtc/libwebrtc/release-while-setting-local-description.html

[Build Bot]

Created attachment 309241 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 309226 [details]
Patch

Attachment 309226 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3681768

New failing tests:
webrtc/libwebrtc/release-while-setting-local-description.html

[Build Bot]

Created attachment 309243 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Ryan Haddad]

(In reply to Build Bot from comment #6)
> Created attachment 309243 [details]
> Archive of layout-test-results from ews124 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/webrtc/libwebrtc/release-while-setting-local-description-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/layout-test-results/webrtc/libwebrtc/release-while-setting-local-description-actual.txt
@@ -1,5 +1,3 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Argument 1 ('candidate') to RTCPeerConnection.addIceCandidate must be an instance of RTCIceCandidate
-CONSOLE MESSAGE: Unhandled Promise Rejection: InvalidStateError (DOM Exception 11): The object is in an invalid state.
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryan Haddad]

Comment 7 is the result of me trying to silence the rejection messages, so it seems that I either did the wrong thing or I need to rebaseline the test, too.

[Ryan Haddad]

Created attachment 309544 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 309544 [details]
Patch

Clearing flags on attachment: 309544

Committed r216548: <http://trac.webkit.org/changeset/216548>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.