LayoutTest js/Promise-types.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r216244%20(831)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2FPromise-types.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/js/Promise-types-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/js/Promise-types-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: 1 +CONSOLE MESSAGE: Unhandled Promise Rejection: 1 Promises - Test basic types / exceptions. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
I'm guessing this test needs the same treatment applied to the tests in https://bugs.webkit.org/show_bug.cgi?id=171445
reproduced locally on Sierra debug with: run-webkit-tests js/Promise-types.html -f --iterations=500 --no-retry-failure -g --debug
(In reply to Ryan Haddad from comment #1) > I'm guessing this test needs the same treatment applied to the tests in > https://bugs.webkit.org/show_bug.cgi?id=171445 Correct that would be sufficient.
Created attachment 310600 [details] Patch
Comment on attachment 310600 [details] Patch r=me
Comment on attachment 310600 [details] Patch Clearing flags on attachment: 310600 Committed r217140: <http://trac.webkit.org/changeset/217140>
All reviewed patches have been landed. Closing bug.
My change managed to break the test when it is run as part of the JSC tests: jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: Exception: ReferenceError: Can't find variable: window https://build.webkit.org/builders/Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434
(In reply to Ryan Haddad from comment #8) > My change managed to break the test when it is run as part of the JSC tests: > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > Exception: ReferenceError: Can't find variable: window > > > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 Ahh yes, I should have realized. You could actually just do: onunhandledrejection = () => false; Without the `window.` portion.
Comment on attachment 310600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310600&action=review > LayoutTests/js/script-tests/Promise-types.js:10 > +// Silence unhandled rejection messages. > +window.onunhandledrejection = () => false; > + This caused the test to always fail in jsc tests.
(In reply to Joseph Pecoraro from comment #9) > (In reply to Ryan Haddad from comment #8) > > My change managed to break the test when it is run as part of the JSC tests: > > > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > > Exception: ReferenceError: Can't find variable: window > > > > > > https://build.webkit.org/builders/ > > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 > > Ahh yes, I should have realized. > > You could actually just do: > > onunhandledrejection = () => false; > > Without the `window.` portion. I verified that making this change fixes the test failure when run locally. I will land a follow up fix to correct my error.
Fixed in https://trac.webkit.org/r217155