WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
171735
[GTK] Add WebKitWebView can-go-back and can-go-forward properties
https://bugs.webkit.org/show_bug.cgi?id=171735
Summary
[GTK] Add WebKitWebView can-go-back and can-go-forward properties
Sébastien Wilmet
Reported
2017-05-05 10:29:36 PDT
It would be nice to have WebKitWebView can-go-back and can-go-forward boolean properties, to update the sensitivity of previous/next buttons.
Attachments
Add attachment
proposed patch, testcase, etc.
Sébastien Wilmet
Comment 1
2017-05-05 10:36:20 PDT
See the following bug in Devhelp to know why I've filed this bug.
https://bugzilla.gnome.org/show_bug.cgi?id=775175
Michael Catanzaro
Comment 2
2017-05-05 11:31:20 PDT
Hm, this should be easy to implement by connecting to the "changed" signal of the WebKitBackForwardList and then calling webkit_web_view_can_go_back() and webkit_web_view_can_go_forward(). That's what Epiphany does, and it's what you could do in Devhelp in the meantime.
Sébastien Wilmet
Comment 3
2017-05-05 13:15:51 PDT
Thanks for the hint, the "changed" signal of WebKitBackForwardList is actually quite convenient to use. With the properties it would anyway not be possible to bind them directly to the GtkButtons sensitivity, because there are several tabs.
Adrian Perez
Comment 4
2018-05-02 10:49:18 PDT
(In reply to Sébastien Wilmet from
comment #3
)
> Thanks for the hint, the "changed" signal of WebKitBackForwardList is > actually quite convenient to use. With the properties it would anyway not be > possible to bind them directly to the GtkButtons sensitivity, because there > are several tabs.
Hi Sébastien! If I understand correctly, here you agreed that using the ::changed signal and calculating whether the buttons should be sensitive ended up being better, isn't it? If that's the case, then I think we can close this as WONTFIX.
Sébastien Wilmet
Comment 5
2018-05-02 11:55:04 PDT
Yes in Devhelp it's actually easier with the ::changed signal.
Adrian Perez
Comment 6
2018-05-02 12:57:11 PDT
(In reply to Sébastien Wilmet from
comment #5
)
> Yes in Devhelp it's actually easier with the ::changed signal.
Great, thanks for closing the issue!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug