Bug 171734 - Refactor / Clean up Element.idl
Summary: Refactor / Clean up Element.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-05 09:57 PDT by Chris Dumez
Modified: 2017-05-05 11:14 PDT (History)
9 users (show)

See Also:


Attachments
Patch (23.92 KB, patch)
2017-05-05 10:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-05 09:57:57 PDT
Refactor / Clean up Element.idl to align with the latest specification:
- https://dom.spec.whatwg.org/#interface-element
Comment 1 Chris Dumez 2017-05-05 10:10:20 PDT
Created attachment 309181 [details]
Patch
Comment 2 Sam Weinig 2017-05-05 10:30:16 PDT
Comment on attachment 309181 [details]
Patch

It's somewhat surprising to me that order in the IDL dictates enumeration order. I can't remember if that is defined or not.  Perhaps we should reify in a sorted order?
Comment 3 Chris Dumez 2017-05-05 10:41:06 PDT
(In reply to Sam Weinig from comment #2)
> Comment on attachment 309181 [details]
> Patch
> 
> It's somewhat surprising to me that order in the IDL dictates enumeration
> order. I can't remember if that is defined or not.  Perhaps we should reify
> in a sorted order?

Perhaps, we should check what WebIDL spec says. I do not know.
Comment 4 Chris Dumez 2017-05-05 10:41:53 PDT
@Sam: I have this small related patch if you have time to review: https://bugs.webkit.org/show_bug.cgi?id=171691
Comment 5 Chris Dumez 2017-05-05 10:51:16 PDT
(In reply to Chris Dumez from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Comment on attachment 309181 [details]
> > Patch
> > 
> > It's somewhat surprising to me that order in the IDL dictates enumeration
> > order. I can't remember if that is defined or not.  Perhaps we should reify
> > in a sorted order?
> 
> Perhaps, we should check what WebIDL spec says. I do not know.

I found https://heycam.github.io/webidl/#legacy-platform-object-property-enumeration which says:
"This document does not define a complete property enumeration order for platform objects implementing interfaces (or for platform objects representing exceptions)."
Comment 6 Chris Dumez 2017-05-05 11:14:17 PDT
Comment on attachment 309181 [details]
Patch

Clearing flags on attachment: 309181

Committed r216251: <http://trac.webkit.org/changeset/216251>
Comment 7 Chris Dumez 2017-05-05 11:14:18 PDT
All reviewed patches have been landed.  Closing bug.