Bug 171734 – Refactor / Clean up Element.idl

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Refactor / Clean up Element.idl to align with the latest specification:
- https://dom.spec.whatwg.org/#interface-element

[Chris Dumez]

Created attachment 309181 [details]
Patch

[Sam Weinig]

Comment on attachment 309181 [details]
Patch

It's somewhat surprising to me that order in the IDL dictates enumeration order. I can't remember if that is defined or not.  Perhaps we should reify in a sorted order?

[Chris Dumez]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 309181 [details]
> Patch
> 
> It's somewhat surprising to me that order in the IDL dictates enumeration
> order. I can't remember if that is defined or not.  Perhaps we should reify
> in a sorted order?

Perhaps, we should check what WebIDL spec says. I do not know.

[Chris Dumez]

@Sam: I have this small related patch if you have time to review: https://bugs.webkit.org/show_bug.cgi?id=171691

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Comment on attachment 309181 [details]
> > Patch
> > 
> > It's somewhat surprising to me that order in the IDL dictates enumeration
> > order. I can't remember if that is defined or not.  Perhaps we should reify
> > in a sorted order?
> 
> Perhaps, we should check what WebIDL spec says. I do not know.

I found https://heycam.github.io/webidl/#legacy-platform-object-property-enumeration which says:
"This document does not define a complete property enumeration order for platform objects implementing interfaces (or for platform objects representing exceptions)."

[Chris Dumez]

Comment on attachment 309181 [details]
Patch

Clearing flags on attachment: 309181

Committed r216251: <http://trac.webkit.org/changeset/216251>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.