Bug 171733 - std::min used without including algorithm
Summary: std::min used without including algorithm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-05 09:55 PDT by Ting-Wei Lan
Modified: 2017-05-12 15:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1019 bytes, patch)
2017-05-05 09:59 PDT, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2017-05-05 09:55:48 PDT 
This causes compilation error on FreeBSD:

In file included from /path/to/WebKit/Source/WebCore/html/track/VTTScanner.cpp:31:
In file included from /path/to/WebKit/Source/WebCore/html/track/VTTScanner.h:32:
In file included from /path/to/WebKit/Source/WebCore/html/parser/ParsingUtilities.h:33:
/path/to/WebKit/Source/WTF/wtf/text/StringCommon.h:482:21: error: no member named 'min' in namespace 'std'
        return std::min(startOffset, sourceStringLength);
               ~~~~~^
/path/to/WebKit/Source/WTF/wtf/text/StringCommon.h:567:21: error: no member named 'min' in namespace 'std'
        return std::min(start, haystack.length());
               ~~~~~^
2 errors generated.
Comment 1 Ting-Wei Lan 2017-05-05 09:59:03 PDT 
Created attachment 309179 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-12 15:05:28 PDT 
Comment on attachment 309179 [details]
Patch

Clearing flags on attachment: 309179

Committed r216796: <http://trac.webkit.org/changeset/216796>
Comment 3 WebKit Commit Bot 2017-05-12 15:05:29 PDT 
All reviewed patches have been landed.  Closing bug.