webrtc/audio-replace-track.html and webrtc/video-replace-track.html fail after r216197. They fail because both create two media streams, and only one media stream at a time is allowed on iOS. After talking to Youenn about this, we decided that the tests should be changed and the logic to allow only one stream should be refactored.
Created attachment 309188 [details] Mark tests as failing
Comment on attachment 309188 [details] Mark tests as failing Clearing flags on attachment: 309188 Committed r216252: <http://trac.webkit.org/changeset/216252>
Created attachment 309228 [details] Patch
Created attachment 309234 [details] Patch
Created attachment 309270 [details] Patch
Comment on attachment 309270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309270&action=review Thanks! > Source/WebCore/ChangeLog:10 > + Renaming MediaStream::endStream by MediaStream::endCaptureTracks and only stopping capture tracks. Nit: "Renaming MediaStream::endStream by MediaStream::endCaptureTracks" => "Rename MediaStream::endStream to MediaStream::endCaptureTracks" > Source/WebCore/ChangeLog:16 > + Adding the ability to have only one active capture source at a time in a WebProcess. > + This is done by keeping in its related factory the active capture source. > + When a new source is created and started, it replaces the active capture source which becomes muted. > + Using that mechanism for iOS. Great idea, very nice!
Created attachment 309325 [details] Patch for landing
Thanks for the review. > Nit: "Renaming MediaStream::endStream by MediaStream::endCaptureTracks" => > "Rename MediaStream::endStream to MediaStream::endCaptureTracks" Done
Comment on attachment 309325 [details] Patch for landing Clearing flags on attachment: 309325 Committed r216349: <http://trac.webkit.org/changeset/216349>
All reviewed patches have been landed. Closing bug.
<rdar://problem/32040952>