Bug 171727 - Commits in branches triggering builds in the bots now
Summary: Commits in branches triggering builds in the bots now
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-05 08:47 PDT by Carlos Garcia Campos
Modified: 2017-05-05 09:01 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-05-05 08:47:30 PDT 
As discussed in webkit-dev it seems that a change in the svn commit hooks made commits in GTK+ stable branches to be shown in the buildbot and triggering builds that don't affect trunk at all. We probably need changes in the hooks but also in the buildbot config. See for example:

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Build)/builds/1366
Comment 1 Alexey Proskuryakov 2017-05-05 09:01:45 PDT 
I believe that Lucas fixed this yesterday.

We now once again use the correct function to parse branch from path in the hook. This function raises an exception when the change is on tag or a release, so no buildbot config changes were needed.