Bug 171716 - DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
Summary: DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-04 23:39 PDT by Mark Lam
Modified: 2017-05-05 09:15 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (6.19 KB, patch)
2017-05-05 00:03 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-05-04 23:39:16 PDT
These functions may do JS allocation.  Hence, they need to acquire the JSLock first.

<rdar://problem/30878027>
Comment 1 Mark Lam 2017-05-05 00:03:50 PDT
Created attachment 309148 [details]
proposed patch.
Comment 2 Mark Lam 2017-05-05 09:15:37 PDT
Thanks for the review.  Landed in r216246: <http://trac.webkit.org/r216246>.