Bug 171713 - Web Automation: cookie-related commands don't work correctly
Summary: Web Automation: cookie-related commands don't work correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-04 21:32 PDT by BJ Burg
Modified: 2022-03-01 02:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.10 KB, patch)
2017-05-04 21:38 PDT, BJ Burg 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-05-04 21:32:51 PDT 
.
Comment 1 BJ Burg 2017-05-04 21:33:04 PDT 
<rdar://problem/29829930>
Comment 2 BJ Burg 2017-05-04 21:38:04 PDT 
Created attachment 309142 [details]
Patch
Comment 3 Alexey Proskuryakov 2017-05-04 22:31:34 PDT 
Comment on attachment 309142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309142&action=review

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:826
> +        if (error != CallbackBase::Error::None)
> +            callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError));
> +        else
> +            callback->sendSuccess();

It seems slightly better to start with success case - avoiding negation makes code a bit easier to understand.
Comment 4 BJ Burg 2017-05-05 12:31:27 PDT 
Committed r216261: <http://trac.webkit.org/changeset/216261>