Bug 171702 - API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
Summary: API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 171586
Blocks: 171800
  Show dependency tree / graph
 
Reported: 2017-05-04 17:54 PDT by Ryan Haddad
Modified: 2017-05-09 08:58 PDT (History)
2 users (show)

See Also:

Attachments
Crashlog (39.19 KB, text/plain)
2017-05-04 17:54 PDT, Ryan Haddad 		no flags Details
proposed patch. (1.55 KB, patch)
2017-05-04 20:20 PDT, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-05-04 17:54:13 PDT 
Created attachment 309119 [details]
Crashlog

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   TestWTF                       	0x00000001028f6882 TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188 (StringView.h:608)
1   TestWTF                       	0x00000001029b8092 testing::Test::Run() + 92
2   TestWTF                       	0x00000001029b8736 testing::internal::TestInfoImpl::Run() + 178
3   TestWTF                       	0x00000001029b8b2e testing::TestCase::Run() + 188
4   TestWTF                       	0x00000001029bc1b7 testing::internal::UnitTestImpl::RunAllTests() + 581
5   TestWTF                       	0x000000010292da43 TestWebKitAPI::TestsController::run(int, char**) + 131 (TestsController.cpp:80)
6   TestWTF                       	0x00000001029b0702 main + 349 (mainMac.mm:52)
7   libdyld.dylib                 	0x00007fff922c65ad start + 1

https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20%28Tests%29/builds/1339/steps/run-api-tests/logs/stdio
Comment 1 Mark Lam 2017-05-04 20:12:14 PDT 
I see the issue.  I forgot to undo a testing change.  I'll test the fix and check it in if all goes well.
Comment 2 Mark Lam 2017-05-04 20:20:51 PDT 
Created attachment 309134 [details]
proposed patch.
Comment 3 Mark Lam 2017-05-04 20:25:58 PDT 
Thanks for the review.  Landed in r216231: <http://trac.webkit.org/r216231>.