Created attachment 309118 [details] patch [Mac] Modernize image for dragged link
Attachment 309118 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309124 [details] Patch
Comment on attachment 309118 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=309118&action=review > Source/WebCore/platform/mac/DragImageMac.mm:161 > +const float linkImagePadding = 10; // Keep in sync with DragController::LinkDragBorderInset. > +const float linkImageDomainBaselineToTitleBaseline = 18; > +const float linkImageCornerRadius = 5; > +const float linkImageMaximumWidth = 400; > +const float linkImageFontSize = 11; Some of these should be CGFloats. > Source/WebCore/platform/mac/DragImageMac.mm:176 > + void layOutText(NSString *text, NSColor *, NSFont *, CFIndex maximumLines, CTLineTruncationType, CGFloat& maximumAvailableWidth, CGFloat& maximumUsedTextWidth, CGFloat& currentY); layOutText is hard on my eyes.
Created attachment 309126 [details] Patch
Comment on attachment 309126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309126&action=review > Source/WebCore/platform/mac/DragImageMac.mm:176 > + void addLine(CTLineRef, Vector<CGPoint>& origins, CFIndex lineIndex, CGFloat x, CGFloat& y, CGFloat& maximumUsedTextWidth, bool isLastLine); Can origins be const?
Sure.
https://trac.webkit.org/changeset/216226/webkit