Bug 17169 – Support transform on Canvas

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Oliver Hunt]

Add transform() support to Canvas

[Oliver Hunt]

Created attachment 18893 [details]
Patch to support transform

[Darin Adler]

Comment on attachment 18893 [details]
Patch to support transform

+    state().m_path.transform(transform.inverse());

Is the transform guaranteed to be invertible? If not, what happens? Does a test case cover this?

[Maciej Stachowiak]

Comment on attachment 18893 [details]
Patch to support transform

Looks good, assuming isfinite checks for NaN as well as infinities (I am not sure if it does).

r=me but please double-check that detail.

[Oliver Hunt]

Landed r29956 -- added an additional nan testcase

[Darin Adler]

(In reply to comment #3)
> Looks good, assuming isfinite checks for NaN as well as infinities (I am not
> sure if it does).

Yes, isfinite(x) === !isnan(x) && !isinf(x).

[Darin Adler]

(In reply to comment #2)
> (From update of attachment 18893 [details] [edit])
> +    state().m_path.transform(transform.inverse());
> 
> Is the transform guaranteed to be invertible? If not, what happens? Does a test
> case cover this?

Ollie?

[Oliver Hunt]

Darin, whoops, didn't see your comment.

It's safe -- it's equivalent to scale(0,0) for example.

That said it should have a testcase which i'll work on after i eat