Bug 171680 - [GTK][JSCOnly] Implement memoryFootprint for Linux
Summary: [GTK][JSCOnly] Implement memoryFootprint for Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-04 12:01 PDT by Yusuke Suzuki
Modified: 2017-05-05 15:09 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2017-05-04 12:03 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.29 KB, patch)
2017-05-04 12:10 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2017-05-04 12:21 PDT, Yusuke Suzuki 		clopez: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-05-04 12:01:15 PDT 
[GTK][JSCOnly] Implement memoryFootprint for Linux
Comment 1 Yusuke Suzuki 2017-05-04 12:03:20 PDT 
Created attachment 309077 [details]
Patch
Comment 2 Yusuke Suzuki 2017-05-04 12:10:55 PDT 
Created attachment 309079 [details]
Patch
Comment 3 Yusuke Suzuki 2017-05-04 12:21:01 PDT 
Created attachment 309083 [details]
Patch
Comment 4 Build Bot 2017-05-04 12:23:32 PDT 
Attachment 309083 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/MemoryFootprint.cpp:74:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Alberto Lopez Perez 2017-05-04 12:43:07 PDT 
Comment on attachment 309083 [details]
Patch

Amazing!
Comment 6 Yusuke Suzuki 2017-05-04 13:00:43 PDT 
Committed r216201: <http://trac.webkit.org/changeset/216201>
Comment 7 Carlos Garcia Campos 2017-05-04 23:16:58 PDT 
Could we use this in the memory pressure handler as the physical memory of MemoryUsage struct?
Comment 8 Yusuke Suzuki 2017-05-05 15:09:00 PDT 
(In reply to Carlos Garcia Campos from comment #7)
> Could we use this in the memory pressure handler as the physical memory of
> MemoryUsage struct?

Yes, we can use it. I'll upload the patch for that.