Bug 171677 – [GTK][WPE] Bump GStreamer version to 1.12 in jhbuild

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Bump GStreamer version to 1.12 in jhbuild: https://gstreamer.freedesktop.org/releases/1.12/

We had some pretty bad timing on the 1.10.4 upgrade. ;) It's very important to test with the latest version.

[Carlos Alberto Lopez Perez]

When doing this, most likely the patch gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch has to be recovered back. Check: 

https://bugs.webkit.org/show_bug.cgi?id=171595#c13

[Carlos Garcia Campos]

I don't think the idea of the new policy is to always use the latest stable version as soon as it's released. The idea of the policy is to try to test with versions as close as possible to what most of the users will end up using. That's why I proposed to bump versions at the beginning of the cycle to the current stable version, that hopefully would be .1 at the time. In bug #170500 I proposed versions bumps checking also what distros ship. So, I would wait a bit before using gst 1.12 that was released yesterday. We all know that the actual stable version is not usually .0 but .1 or even .2.

[Xabier Rodríguez Calvar]

(In reply to Carlos Garcia Campos from comment #2)
> I don't think the idea of the new policy is to always use the latest stable
> version as soon as it's released. The idea of the policy is to try to test
> with versions as close as possible to what most of the users will end up
> using. That's why I proposed to bump versions at the beginning of the cycle
> to the current stable version, that hopefully would be .1 at the time. In
> bug #170500 I proposed versions bumps checking also what distros ship. So, I
> would wait a bit before using gst 1.12 that was released yesterday. We all
> know that the actual stable version is not usually .0 but .1 or even .2.

Exactly.

[Michael Catanzaro]

(In reply to Carlos Garcia Campos from comment #2)
> I don't think the idea of the new policy is to always use the latest stable
> version as soon as it's released. The idea of the policy is to try to test
> with versions as close as possible to what most of the users will end up
> using. That's why I proposed to bump versions at the beginning of the cycle
> to the current stable version, that hopefully would be .1 at the time. In
> bug #170500 I proposed versions bumps checking also what distros ship. So, I
> would wait a bit before using gst 1.12 that was released yesterday. We all
> know that the actual stable version is not usually .0 but .1 or even .2.

I think that usually works, but this time around GStreamer and GNOME release cycles seem to no longer be in sync. We are definitely going to be shipping GStreamer 1.12 to Fedora users next month.

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #4)
> (In reply to Carlos Garcia Campos from comment #2)
> > I don't think the idea of the new policy is to always use the latest stable
> > version as soon as it's released. The idea of the policy is to try to test
> > with versions as close as possible to what most of the users will end up
> > using. That's why I proposed to bump versions at the beginning of the cycle
> > to the current stable version, that hopefully would be .1 at the time. In
> > bug #170500 I proposed versions bumps checking also what distros ship. So, I
> > would wait a bit before using gst 1.12 that was released yesterday. We all
> > know that the actual stable version is not usually .0 but .1 or even .2.
> 
> I think that usually works, but this time around GStreamer and GNOME release
> cycles seem to no longer be in sync. We are definitely going to be shipping
> GStreamer 1.12 to Fedora users next month.

Are you going to deal with test failures and bugs in WebKit and/or GST?

[Michael Catanzaro]

I can certainly update expectations and file WebKit bugs.

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #6)
> I can certainly update expectations and file WebKit bugs.

No, I don't want tests skipped forever, but bugs fixed instead.

[Michael Catanzaro]

Well if you prefer not knowing about bugs affecting our users at all, then sure, let's stick with 1.10.4 for a while....

[Carlos Alberto Lopez Perez]

Is now a good time to bump gstreamer modules to 1.12? Debian testing is now shipping 1.12

[Xabier Rodríguez Calvar]

I don't object.

[Carlos Garcia Campos]

Yes, perfect timing.

[Carlos Alberto Lopez Perez]

Created attachment 329105 [details]
Patch

[Carlos Alberto Lopez Perez]

Created attachment 329107 [details]
Patch

Minor cosmetic fix

[Carlos Alberto Lopez Perez]

Comment on attachment 329107 [details]
Patch

Clearing flags on attachment: 329107

Committed r225780: <https://trac.webkit.org/changeset/225780>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.