Bug 171652 - Avoid descending to sublayers when coverage rect doesn't change
Summary: Avoid descending to sublayers when coverage rect doesn't change
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-04 05:30 PDT by Antti Koivisto
Modified: 2017-05-04 11:36 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.77 KB, patch)
2017-05-04 05:35 PDT, Antti Koivisto 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-05-04 05:30:16 PDT 
Currently NeedsComputeVisibleAndCoverageRect is treated as a change that affects sublayers. This is unnecessary if nothing actually changes as a result of the computation.
Comment 1 Antti Koivisto 2017-05-04 05:35:19 PDT 
Created attachment 309034 [details]
patch
Comment 2 Geoffrey Garen 2017-05-04 08:29:29 PDT 
Comment on attachment 309034 [details]
patch

r=me
Comment 3 Simon Fraser (smfr) 2017-05-04 08:32:08 PDT 
Comment on attachment 309034 [details]
patch

Does this help performance in some scenario not mentioned here?
Comment 4 Antti Koivisto 2017-05-04 11:36:15 PDT 
No. I just noticed I was trivially leaving some performance on table in the earlier patch. I'm not aware of any real world case where this matters.