RESOLVED FIXED171641
Rename testRunner.display() to testRunner.displayAndTrackRepaints() 
https://bugs.webkit.org/show_bug.cgi?id=171641
Summary Rename testRunner.display() to testRunner.displayAndTrackRepaints()
Said Abou-Hallawa
Reported 2017-05-03 18:03:18 PDT
The plan is to add back the TestRunner.display() which does the display only with the track repaints.
Attachments
Patch (118.45 KB, patch)
2017-05-03 18:28 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (118.42 KB, patch)
2017-05-03 18:42 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (118.56 KB, patch)
2017-05-04 08:29 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (118.50 KB, patch)
2017-05-04 08:36 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (118.45 KB, patch)
2017-05-04 08:53 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (117.36 KB, patch)
2017-05-04 09:10 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (116.63 KB, patch)
2017-05-04 09:14 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (117.43 KB, patch)
2017-05-04 11:17 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2017-05-03 18:28:04 PDT
Created attachment 308999 [details] Patch
Said Abou-Hallawa
Comment 2 2017-05-03 18:42:25 PDT
Created attachment 309000 [details] Patch
Said Abou-Hallawa
Comment 3 2017-05-04 08:29:40 PDT
Created attachment 309047 [details] Patch
Said Abou-Hallawa
Comment 4 2017-05-04 08:36:09 PDT
Created attachment 309048 [details] Patch
Said Abou-Hallawa
Comment 5 2017-05-04 08:53:36 PDT
Created attachment 309052 [details] Patch
Said Abou-Hallawa
Comment 6 2017-05-04 09:10:47 PDT
Created attachment 309053 [details] Patch
Said Abou-Hallawa
Comment 7 2017-05-04 09:14:00 PDT
Created attachment 309054 [details] Patch
Said Abou-Hallawa
Comment 8 2017-05-04 11:17:47 PDT
Created attachment 309067 [details] Patch
Simon Fraser (smfr)
Comment 9 2017-05-04 14:02:42 PDT
Comment on attachment 309067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309067&action=review > Tools/DumpRenderTree/TestRunner.h:-73 > - void displayInvalidatedRegion(); What happened to displayInvalidatedRegion()? Is it unused?
Said Abou-Hallawa
Comment 10 2017-05-04 14:17:14 PDT
Comment on attachment 309067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309067&action=review >> Tools/DumpRenderTree/TestRunner.h:-73 >> - void displayInvalidatedRegion(); > > What happened to displayInvalidatedRegion()? Is it unused? This function is weird. Its callback displayInvalidatedRegionCallback() is just a copy of displayCallback() and this is the case since it was initially created in https://trac.webkit.org/changeset/78010/webkit. It is used in two tests and both of them do not work reliably on all platforms: (1) compositing/plugins/invalidate_rect.html: LayoutTests//platform/mac/TestExpectations:webkit.org/b/114321 compositing/plugins/invalidate_rect.html [ Failure Pass ] LayoutTests//platform/wk2/TestExpectations:compositing/plugins/invalidate_rect.html (2) plugins/windowless_plugin_paint_test.html LayoutTests//platform/win/TestExpectations:webkit.org/b/57693 plugins/windowless_plugin_paint_test.html [ Skip ] LayoutTests//platform/wk2/TestExpectations:plugins/windowless_plugin_paint_test.html
WebKit Commit Bot
Comment 11 2017-05-04 14:46:44 PDT
Comment on attachment 309067 [details] Patch Clearing flags on attachment: 309067 Committed r216211: <http://trac.webkit.org/changeset/216211>
WebKit Commit Bot
Comment 12 2017-05-04 14:46:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.