Bug 171639 - Maintain interaction information imageURL as a URL, not a string
Summary: Maintain interaction information imageURL as a URL, not a string
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-03 17:48 PDT by Tim Horton
Modified: 2017-05-04 10:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2017-05-03 17:48 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-05-03 17:48:04 PDT 
Maintain interaction information imageURL as a URL, not a string
Comment 1 Tim Horton 2017-05-03 17:48:13 PDT 
Created attachment 308993 [details]
Patch
Comment 2 Sam Weinig 2017-05-03 17:58:10 PDT 
Comment on attachment 308993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308993&action=review

> Source/WebKit2/ChangeLog:4
> +        Maintain interaction information imageURL as a URL, not a string
> +        https://bugs.webkit.org/show_bug.cgi?id=171639

Ok. But why? Just because it is better?
Comment 3 Tim Horton 2017-05-03 18:06:17 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 308993 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308993&action=review
> 
> > Source/WebKit2/ChangeLog:4
> > +        Maintain interaction information imageURL as a URL, not a string
> > +        https://bugs.webkit.org/show_bug.cgi?id=171639
> 
> Ok. But why? Just because it is better?

Is that so bad? :) But no, there is a good reason (for url, not for imageURL, but no point changing one and not the other).
Comment 4 WebKit Commit Bot 2017-05-03 19:03:02 PDT 
Comment on attachment 308993 [details]
Patch

Clearing flags on attachment: 308993

Committed r216168: <http://trac.webkit.org/changeset/216168>
Comment 5 WebKit Commit Bot 2017-05-03 19:03:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Sam Weinig 2017-05-04 10:51:52 PDT 
(In reply to Tim Horton from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Comment on attachment 308993 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=308993&action=review
> > 
> > > Source/WebKit2/ChangeLog:4
> > > +        Maintain interaction information imageURL as a URL, not a string
> > > +        https://bugs.webkit.org/show_bug.cgi?id=171639
> > 
> > Ok. But why? Just because it is better?
> 
> Is that so bad? :) 

Nope. Consistency is a fine reason.

> But no, there is a good reason (for url, not for
> imageURL, but no point changing one and not the other).

What was the reason?