RESOLVED FIXED 171633
Add support for reading and writing settings from UIProcess audio capture 
https://bugs.webkit.org/show_bug.cgi?id=171633
Summary Add support for reading and writing settings from UIProcess audio capture
youenn fablet
Reported 2017-05-03 16:38:51 PDT
Currently we are not able to do so, which limits the usefulness of getSettings() and applyConstraints for audio tracks. See radar 31878098 also.
Attachments
Patch (34.26 KB, patch)
2017-05-03 17:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Rebasing patch (37.20 KB, patch)
2017-05-03 22:33 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.47 KB, patch)
2017-05-05 14:54 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.85 KB, patch)
2017-05-05 23:25 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing start/stop and using last client (39.62 KB, patch)
2017-05-07 11:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (37.12 KB, patch)
2017-05-08 15:05 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-05-03 17:13:55 PDT
Created attachment 308991 [details] Patch
Eric Carlson
Comment 2 2017-05-03 17:38:29 PDT
Comment on attachment 308991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308991&action=review > Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:306 > Nit: extra blank > Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:147 > + settings = source->settings(); Why is this necessary?
youenn fablet
Comment 3 2017-05-03 22:33:56 PDT
Created attachment 309018 [details] Rebasing patch
youenn fablet
Comment 4 2017-05-03 22:34:59 PDT
(In reply to youenn fablet from comment #3) > Created attachment 309018 [details] > Rebasing patch Plus some minor clean-up to CoreAudioCaptureSource. Let's see whether it compiles and passes tests.
youenn fablet
Comment 5 2017-05-05 14:54:25 PDT
Created attachment 309216 [details] Patch for landing
youenn fablet
Comment 6 2017-05-05 23:25:15 PDT
Created attachment 309272 [details] Patch for landing
youenn fablet
Comment 7 2017-05-07 11:28:38 PDT
Created attachment 309324 [details] Fixing start/stop and using last client
Radar WebKit Bug Importer
Comment 8 2017-05-07 19:21:43 PDT
<rdar://problem/32041545>
youenn fablet
Comment 9 2017-05-08 15:05:54 PDT
Created attachment 309419 [details] Patch
WebKit Commit Bot
Comment 10 2017-05-08 16:31:59 PDT
Comment on attachment 309419 [details] Patch Clearing flags on attachment: 309419 Committed r216463: <http://trac.webkit.org/changeset/216463>
WebKit Commit Bot
Comment 11 2017-05-08 16:32:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.