Bug 171624 - Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
Summary: Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 171565
  Show dependency tree / graph
 
Reported: 2017-05-03 15:27 PDT by Chris Dumez
Modified: 2017-05-05 11:11 PDT (History)
7 users (show)

See Also:

Attachments
WIP Patch (34.02 KB, patch)
2017-05-03 19:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (49.25 KB, patch)
2017-05-03 19:16 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (49.31 KB, patch)
2017-05-05 10:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-03 15:27:13 PDT 
WebPageProxy::processDidCrash() is called twice in case of termination due to resource limits after r216129.
Comment 1 Chris Dumez 2017-05-03 19:03:40 PDT 
Created attachment 309001 [details]
WIP Patch
Comment 2 Chris Dumez 2017-05-03 19:16:23 PDT 
Created attachment 309002 [details]
Patch
Comment 3 Chris Dumez 2017-05-04 20:51:47 PDT 
ping review?
Comment 4 mitz 2017-05-05 09:20:38 PDT 
Comment on attachment 309002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309002&action=review

> Source/WebKit2/ChangeLog:3
> +        Rename webProcessDidCrashWithReason delegate to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations

“delegate” is a term normally used in Cocoa API. C APIs usually call these things “clients” and “client callbacks”.
Comment 5 Chris Dumez 2017-05-05 10:00:22 PDT 
Created attachment 309180 [details]
Patch
Comment 6 WebKit Commit Bot 2017-05-05 11:11:50 PDT 
Comment on attachment 309180 [details]
Patch

Clearing flags on attachment: 309180

Committed r216249: <http://trac.webkit.org/changeset/216249>
Comment 7 WebKit Commit Bot 2017-05-05 11:11:52 PDT 
All reviewed patches have been landed.  Closing bug.