Bug 171612 - Fix compilation with ICU 59.1
Summary: Fix compilation with ICU 59.1
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
Depends on:
Reported: 2017-05-03 12:50 PDT by Konstantin Tokarev
Modified: 2017-05-04 08:33 PDT (History)
11 users (show)

See Also:

Patch (6.58 KB, patch)
2017-05-03 12:52 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2017-05-03 12:55 PDT, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-05-03 12:50:16 PDT
ICU 59.1 has broken source compatibility. Now it defines UChar as char16_t, which does not allow automatic type conversion from unsigned short in C++ code.
Comment 1 Konstantin Tokarev 2017-05-03 12:52:40 PDT
Created attachment 308941 [details]
Comment 2 Konstantin Tokarev 2017-05-03 12:55:04 PDT
Created attachment 308942 [details]
Comment 3 Mark Lam 2017-05-03 15:40:12 PDT
Comment on attachment 308942 [details]

Comment 4 Michael Catanzaro 2017-05-03 16:24:14 PDT
static_cast does not work...? Really? I think it should.
Comment 5 Konstantin Tokarev 2017-05-04 01:07:53 PDT
static_cast doesn't cast pointers to different types
Comment 6 Konstantin Tokarev 2017-05-04 01:08:21 PDT
s/different/unrelated/, sorry
Comment 7 WebKit Commit Bot 2017-05-04 08:33:45 PDT
Comment on attachment 308942 [details]

Clearing flags on attachment: 308942

Committed r216187: <http://trac.webkit.org/changeset/216187>
Comment 8 WebKit Commit Bot 2017-05-04 08:33:46 PDT
All reviewed patches have been landed.  Closing bug.