Created attachment 308929 [details] Crashlog LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r216023%20(1169)/media/modern-media-controls/placard-support/placard-support-pip-crash-log.txt https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fplacard-support%2Fplacard-support-pip.html
The crash is beneath WebKit in AVPlayer. Application Specific Information: CRASHING TEST: media/modern-media-controls/placard-support/placard-support-pip.html *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'An instance 0x7fe5a8655d60 of class AVPlayer was deallocated while key value observers were still registered with it. Current observation info: <NSKeyValueObservationInfo 0x7fe5a80ddce0> ( <NSKeyValueObservance 0x7fe5a795a600: Observer: 0x7fe5a7bd8e50, Key path: rate, Options: <New: NO, Old: NO, Prior: NO> Context: 0x0, Property: 0x7fe5a7eecee0> )' terminating with uncaught exception of type NSException abort() called
Maybe this has something to do with the "workaround" that was removed from media/modern-media-controls/pip-support/pip-support-click.html in https://trac.webkit.org/changeset/215951/webkit
<rdar://problem/31976820>
Skipped media/modern-media-controls/pip-support/pip-support-click.html to see if that stops the crashes in https://trac.webkit.org/r216191
(In reply to Ryan Haddad from comment #4) > Skipped media/modern-media-controls/pip-support/pip-support-click.html to > see if that stops the crashes in https://trac.webkit.org/r216191 I'm able to report the problem by doing run-webkit-tests LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html -1 --child-processes=1
Created attachment 309132 [details] Patch
Created attachment 309133 [details] Patch
Comment on attachment 309133 [details] Patch Clearing flags on attachment: 309133 Committed r216245: <http://trac.webkit.org/changeset/216245>
All reviewed patches have been landed. Closing bug.