Bug 171608 - RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_RENDER_OBJECT
Summary: RenderSearchField should not use isTextField() in SPECIALIZE_TYPE_TRAITS_REND...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-03 11:11 PDT by zalan
Modified: 2017-05-03 13:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2017-05-03 11:14 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-05-03 11:11:32 PDT
it enables erroneous downcasting.
Comment 1 zalan 2017-05-03 11:14:13 PDT
Created attachment 308927 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-03 12:16:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 308927 [details]:

http/tests/security/cross-origin-xsl-BLOCKED.html bug 51054 (authors: abarth@webkit.org, jochen@chromium.org, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2017-05-03 12:17:22 PDT
Comment on attachment 308927 [details]
Patch

Clearing flags on attachment: 308927

Committed r216131: <http://trac.webkit.org/changeset/216131>
Comment 4 WebKit Commit Bot 2017-05-03 12:17:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 zalan 2017-05-03 13:50:59 PDT
rdar://problem/31971507