Bug 171607 - Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge
Summary: Handle KVO updating of the "hasOnlySecureContent" before a page results in an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-03 11:08 PDT by Brady Eidson
Modified: 2017-05-03 12:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2017-05-03 11:18 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (1.48 KB, patch)
2017-05-03 11:56 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-05-03 11:08:58 PDT 
Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge

<rdar://problem/28867282>
Comment 1 Brady Eidson 2017-05-03 11:18:07 PDT 
Created attachment 308930 [details]
Patch
Comment 2 Andy Estes 2017-05-03 11:20:13 PDT 
Comment on attachment 308930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308930&action=review

> Source/WebKit2/UIProcess/PageLoadState.cpp:209
> +    if (data.state == State::Provisional)
> +        return WebCore::protocolIs(data.provisionalURL, "https");

Feels like a blank line belongs at the end of this.
Comment 3 Brady Eidson 2017-05-03 11:56:40 PDT 
Created attachment 308934 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-03 12:27:09 PDT 
Comment on attachment 308934 [details]
Patch

Clearing flags on attachment: 308934

Committed r216132: <http://trac.webkit.org/changeset/216132>
Comment 5 WebKit Commit Bot 2017-05-03 12:27:11 PDT 
All reviewed patches have been landed.  Closing bug.